Port away from KIconThemes
ClosedPublic

Authored by nicolasfella on Jan 2 2020, 3:46 PM.

Details

Summary

IconSize is deprecated.

Using the "Desktop" icon size was somewhat arbitrary. There is no QStyle pixelmetric that offers the same size and fits semantically.

Test Plan

Side panel, properties dialog and extraction dialog look the same

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jan 2 2020, 3:46 PM
Restricted Application added a project: Ark. · View Herald TranscriptJan 2 2020, 3:46 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 2 2020, 3:46 PM
  • Remove include
nicolasfella edited the summary of this revision. (Show Details)Jan 2 2020, 3:59 PM
  • Do the rest
nicolasfella retitled this revision from Port away from deprecated IconSize function to Port away from KIconThemes.Jan 2 2020, 5:44 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jan 2 2020, 5:49 PM
This revision is now accepted and ready to land.Jan 2 2020, 5:49 PM
This revision was automatically updated to reflect the committed changes.

@nicolasfella I don't like the hardcoding of 48. If there is no clean way to port IconSize(KIconLoader::Desktop), I'd prefer to port to a different non-hardcoded size.

kerfuffle/extractiondialog.cpp
85

We can use PM_LargeIconSize here.

kerfuffle/propertiesdialog.cpp
104

We can use PM_LargeIconSize here. The icon in the properties dialog is pointless anyway.

part/infopanel.cpp
35

Why remove static ?

36

The infopanel is the only place where the Desktop size made sense (lots of space), at most we can hardcode 48 only here.