Use const as need be.
Use QList::at() where possible.
Details
Details
make && ctest
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/urifilters/ikws/kuriikwsfiltereng.cpp | ||
|---|---|---|
| 144 | declare where first used (2 lines down) | |
| 149 | Are you sure about the += here? | |
| 150 | this kind of duplicates line 142. Would it be more readable to do like you did in some other places, like while ((match = qsexpr.match(userquery, start)).hasMatch()) ? | |
| 245 | declare where first used | |
| 319 | same comment as above | |
| 320 | same comment as above | |
Comment Actions
Address comments:
Search offset can't be +=, since the position is moves with capturedStart().
More compact code, always declare where used (don't micro-optimise?)