Add application/vnd.apple.pkpass icon
ClosedPublic

Authored by broulik on Mon, Dec 30, 11:55 PM.

Details

Summary

BUG: 397987

Test Plan

My boarding passes have nice icons now :)

Since pkpass can also be used for concert tickets and exhibition entrance passes, I felt adding an airplane was wrong. While I loved the QR code idea, it didn't really work out well at 16px size, neither did an Aztec code, so I chose to use a "wallet" (basically wallet-open, adjusted) icon instead.

16


22

32

48

64

(note I have high dpi, so the actual pixels are doubled)

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mon, Dec 30, 11:55 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Dec 30, 11:55 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mon, Dec 30, 11:55 PM
ndavis requested changes to this revision.Tue, Dec 31, 1:46 AM
ndavis added a subscriber: ndavis.

Nice work!

Looks like the 64px version got a part of it knocked out of position:

Once that's fixed, run it through an optimizer and copy these to the icons-dark folder.

https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

This revision now requires changes to proceed.Tue, Dec 31, 1:46 AM

Awesome, thanks!

broulik updated this revision to Diff 72464.Tue, Dec 31, 9:59 AM
  • Fix misaligned object
  • Optimize SVGs (also remove unused stylesheet from monochrome icons)
  • Copy to breeze-dark
ndavis accepted this revision.Tue, Dec 31, 11:03 AM
This revision is now accepted and ready to land.Tue, Dec 31, 11:03 AM
This revision was automatically updated to reflect the committed changes.