Add application/vnd.apple.pkpass icon
ClosedPublic
Actions

Authored by broulik on Dec 30 2019, 11:55 PM.

Details

Reviewers

vkrause
ndavis

Group Reviewers

VDG

Commits

R266:eca72cb0689b: Add application/vnd.apple.pkpass icon

Summary

BUG: 397987

Test Plan

My boarding passes have nice icons now :)

Since pkpass can also be used for concert tickets and exhibition entrance passes, I felt adding an airplane was wrong. While I loved the QR code idea, it didn't really work out well at 16px size, neither did an Aztec code, so I chose to use a "wallet" (basically wallet-open, adjusted) icon instead.

(note I have high dpi, so the actual pixels are doubled)

Diff Detail

Repository

R266 Breeze Icons

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Dec 30 2019, 11:55 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 30 2019, 11:55 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Dec 30 2019, 11:55 PM

Nice work!

Looks like the 64px version got a part of it knocked out of position:

Once that's fixed, run it through an optimizer and copy these to the icons-dark folder.

https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

This revision now requires changes to proceed.Dec 31 2019, 1:46 AM

Awesome, thanks!

Fix misaligned object
Optimize SVGs (also remove unused stylesheet from monochrome icons)
Copy to breeze-dark

ndavis accepted this revision.Dec 31 2019, 11:03 AM

This revision is now accepted and ready to land.Dec 31 2019, 11:03 AM

Closed by commit R266:eca72cb0689b: Add application/vnd.apple.pkpass icon (authored by broulik). · Explain WhyDec 31 2019, 11:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	icons-dark/mimetypes/16/application-vnd.apple.pkpass.svg (3 lines)
A	M	icons-dark/mimetypes/22/application-vnd.apple.pkpass.svg (3 lines)
A	M	icons-dark/mimetypes/32/application-vnd.apple.pkpass.svg (26 lines)
A	M	icons-dark/mimetypes/64/application-vnd.apple.pkpass.svg (26 lines)
A	M	icons/mimetypes/16/application-vnd.apple.pkpass.svg (3 lines)
A	M	icons/mimetypes/22/application-vnd.apple.pkpass.svg (3 lines)
A	M	icons/mimetypes/32/application-vnd.apple.pkpass.svg (26 lines)
A	M	icons/mimetypes/64/application-vnd.apple.pkpass.svg (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72432			Dec 30 2019, 11:52 PM	★	★
Diff 2	72464			Dec 31 2019, 9:59 AM	★	★
Diff 3	72477	7a39dc7	R266:eca72cb0689b5b95872f7c5e529eb7a8c357b8eb	Dec 31 2019, 11:05 AM	★	★