Port QRegExp to QRegularExpression
Needs ReviewPublic

Authored by ahmadsamir on Dec 24 2019, 6:44 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Summary

Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern().
Port QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression().
Note that QRegularExpression::wildcardToRegularExpression() returns an anchored
pattern.

KFileItemModelFilter still uses QRegExp as there's no equivalent in QRegularExpression
to QRegExp::WildcardUnix.

Test Plan

make && ctest

All unit tests pass, except:

  • kfileitemmodeltest (which is unrelated AFAICS); it fails on master too
  • dolphinquerytest, this one seems to require baloo which I don't use on my setup

Diff Detail

Repository
R318 Dolphin
Branch
l-qregularexpression (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22207
Build 22225: arc lint + arc unit
ahmadsamir created this revision.Dec 24 2019, 6:44 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 24 2019, 6:44 PM
ahmadsamir requested review of this revision.Dec 24 2019, 6:44 PM
ahmadsamir planned changes to this revision.Jan 16 2020, 3:10 PM
ahmadsamir updated this revision to Diff 75215.Feb 8 2020, 8:52 AM
ahmadsamir edited the summary of this revision. (Show Details)
ahmadsamir edited the test plan for this revision. (Show Details)

Update diff