Differential D26208

[KEmailAddress] Remove redundant bool var
ClosedPublic
Actions

Authored by ahmadsamir on Dec 24 2019, 10:04 AM.

Details

Reviewers
dfaure
ngraham
Commits
R270:9e8f0306b549: [KEmailAddress] Remove redundant bool var
Summary

It looks like 'bool tooManyAtsFlag' was copied over from isValidAddress()
(where it's actually used/useful) to isValidSimpleAddress() where it's
redundant.

Diff Detail

Repository
R270 KCodecs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 24 2019, 10:04 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 24 2019, 10:04 AM
ahmadsamir requested review of this revision.Dec 24 2019, 10:04 AM
meven added a subscriber: meven.Dec 30 2019, 2:34 PM

Seems fine to me, indeed this bool was never changed

ngraham accepted this revision.Dec 30 2019, 6:06 PM
This revision is now accepted and ready to land.Dec 30 2019, 6:06 PM
Closed by commit R270:9e8f0306b549: [KEmailAddress] Remove redundant bool var (authored by ahmadsamir). · Explain WhyJan 2 2020, 1:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kemailaddress.cpp (6 lines)

Diff 72611

View Options

src/kemailaddress.cpp

Loading...