The lack of standard way to close a page has always bothered me, particularly on the desktop. On mobile this is less of an issue since there is always only one page visible. Discover and Calindori have implemented Esc as shortcut for closing a page already.
Details
Details
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- close
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20230 Build 20248: arc lint + arc unit
Comment Actions
Shouldn't the application control whether its pages get closed and under which condition it happens?
Comment Actions
Maybe, but I think there is some value to having this handled by the toolkit to ensure behavioral consistency across apps.
Comment Actions
hmm, not sure about it.
it would probably be ok for most of the cases, but i'm pretty sure it may break some existing app.
an app may want at least two pages always loaded for instance (if uses one for sidebar, one for main content)
Comment Actions
We could handle that by having the keystroke only get passed to the page with implicit focus, right?