Display fully qualified class/namespace name as page header
ClosedPublic

Authored by davidre on Mon, Dec 23, 8:42 PM.

Details

Summary

It's the most important information to see quickly what the page is about.
Using the fully qualified name contains the knowledge which namespace contains a
class/another namespace required which is helpful if one wants to use it in their
own code.

BUG: 406588

Test Plan

Class:


Namespace:

Class inside namespace:

Nested namespace:

Class inside nested namespace:

Diff Detail

Repository
R264 KApiDox
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Mon, Dec 23, 8:42 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptMon, Dec 23, 8:42 PM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Mon, Dec 23, 8:42 PM
davidre edited the test plan for this revision. (Show Details)Mon, Dec 23, 8:50 PM
davidre edited the test plan for this revision. (Show Details)
davidre edited the summary of this revision. (Show Details)
davidre added a subscriber: jucato.
aacid added a subscriber: aacid.Tue, Dec 24, 11:07 AM

I've no idea about the code, but looks sensible to me, so take this as a +2 if noone reviews in a while i guess :)

Looks sensible to me too FWIW.

One minor correction then you can ship it

src/kapidox/generator.py
459

Prefer the use of 2 settings to None instead of this double one. It's more explicit for people not coming from python (majority here).

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Dec 27, 2:00 PM
This revision was automatically updated to reflect the committed changes.