added multilevel datasets
- 1st level has grid of size 4
- 6 sublevels
- 2nd level has grid of size 6,7
- 6 sublevels
- 3rd level has grids from size 4 to 8
- 26 sublevels
Details
Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T12418: Add multiple levels in redraw activity
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Branch
- multiple_levels_in_mirror_Shubham
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20259 Build 20277: arc lint + arc unit
Comment Actions
Thanks for the patch.
When saving the configuration from the menu: qrc:/gcompris/src/activities/redraw/Redraw.qml:427: Error: Cannot assign to non-existent property "currentLevel"
This is causing the issue that when you update the dataset in config, it is not updated directly in the activity.
Can you please rephrase the objectives? "Select a grid size of 4" is not very clear on what is aimed for the child.
| src/activities/redraw/redraw.js | ||
|---|---|---|
| 47 ↗ | (On Diff #72128) | no need to update this, keep the spaces before and after |
| src/activities/redraw/resource/3/Data.qml | ||
| 26 ↗ | (On Diff #72128) | up to |
Comment Actions
Fixed the error, rephrased the objectives as well but now it is affecting redraw_symmetric activity. For redraw_symmetric it is looking for a data in src/activities/redraw_symmetric/resource folder but i want them to share data of redraw activity . can you help me in this?
Comment Actions
Can you please change the objectives to: "small grids", "medium grids" and "large grids"?
No need to add size information for now, we will see if we have the need to add more datasets later.
Please duplicate the datasets in both activities. Not the cleanest way, but it will be easier for adding levels in redraw_symmetric if needed and generating documentation for all the activities later.
Comment Actions
Tested this morning, this is totally functionnal for both redraw and redraw_symmertrical.