Added multilevel dataset in redraw and redraw_symmetrical activity
ClosedPublic

Authored by shubhammishra on Dec 23 2019, 12:09 PM.

Details

Summary

added multilevel datasets

  • 1st level has grid of size 4
    • 6 sublevels
  • 2nd level has grid of size 6,7
    • 6 sublevels
  • 3rd level has grids from size 4 to 8
    • 26 sublevels

Diff Detail

Repository
R2 GCompris
Branch
multiple_levels_in_mirror_Shubham
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20261
Build 20279: arc lint + arc unit
shubhammishra requested review of this revision.Dec 23 2019, 12:09 PM
shubhammishra created this revision.
shubhammishra edited the summary of this revision. (Show Details)
shubhammishra retitled this revision from Added multilevel dataset in redraw activity to Added multilevel dataset in redraw and redraw_symmetrical activity.

Updating D26186: Added multilevel dataset in redraw and redraw_symmetrical activity

Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 24 2019, 4:28 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript

Thanks for the patch.

When saving the configuration from the menu: qrc:/gcompris/src/activities/redraw/Redraw.qml:427: Error: Cannot assign to non-existent property "currentLevel"
This is causing the issue that when you update the dataset in config, it is not updated directly in the activity.

Can you please rephrase the objectives? "Select a grid size of 4" is not very clear on what is aimed for the child.

src/activities/redraw/redraw.js
47

no need to update this, keep the spaces before and after

src/activities/redraw/resource/3/Data.qml
27

up to

Fixed the error, rephrased the objectives as well but now it is affecting redraw_symmetric activity. For redraw_symmetric it is looking for a data in src/activities/redraw_symmetric/resource folder but i want them to share data of redraw activity . can you help me in this?

  • updated diff
  • deleted extra empty file

Can you please change the objectives to: "small grids", "medium grids" and "large grids"?
No need to add size information for now, we will see if we have the need to add more datasets later.

Fixed the error, rephrased the objectives as well but now it is affecting redraw_symmetric activity. For redraw_symmetric it is looking for a data in src/activities/redraw_symmetric/resource folder but i want them to share data of redraw activity . can you help me in this?

Please duplicate the datasets in both activities. Not the cleanest way, but it will be easier for adding levels in redraw_symmetric if needed and generating documentation for all the activities later.

  • change objectives and added duplicate dataset in redraw_symmetric

Tested this morning, this is totally functionnal for both redraw and redraw_symmertrical.

This revision is now accepted and ready to land.Dec 27 2019, 10:11 AM
jjazeix closed this revision.Dec 27 2019, 10:12 AM