| dfaure | |
| ervin | |
| apol |
| Frameworks |
Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern()
to match the entire subject string.
Remove filenameOnly(), it's been broken for a long time (QStringLiteral("[/\\]")
is not a valid QRegExp pattern); besides it's not needed as QFileInfo::fileName()
is used to get the filename.
make && ctest
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
IINM, fileNameOnly() can be safely deleted; it's only used once on line 2226:
fileNameOnly(baseName)
and baseName is initialised on line 1630:
QString baseName = QFileInfo(codegenFilename).fileName();
so it's the filename only, excluding the path, so it'll never have / or \ in it, IIUC. And the fact it's been broken at least since the kdelibs split in 2013.
Looks good to me. Not putting the accept flag yet to give more times to others to review those critical bits.
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 643–644 | I wonder if qMax(path.lastIndexOf('/'), path.lastIndexOf('\\')) wouldn't be simpler and faster :-) But yes you're right, might as well just delete this function. | |
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 643–644 | Yep; (and who knows if Qt docs were as expansive/exhaustive as they're now :)). And then fileNameOnly() became unneeded when QFileInfo was used in the code. | |
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 643–644 | I do, and they were, that was always a big selling point for Qt ;) (I started contributing to KDE at the time of Qt 1.1, in 1998) | |
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 643–644 | :D | |