Differential D26169

[DolphinContextMenu] Use contains check for scheme again
ClosedPublic
Actions

Authored by broulik on Dec 22 2019, 11:28 PM.

Details

Reviewers
elvisangelaccio
meven
ngraham
Group Reviewers
Dolphin
Commits
R318:151a17e04800: [DolphinContextMenu] Use contains check for scheme again
Summary

Regression introduced in 8b0c12a59ccb23fdb6393f640693d21afaeb02a1
There's "filenamesearch" and "baloosearch".

Test Plan
  • I have "open path in new tab" for search results again

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 22 2019, 11:28 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 22 2019, 11:28 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Dec 22 2019, 11:28 PM
ngraham accepted this revision.Dec 23 2019, 12:24 AM
ngraham added a subscriber: ngraham.

Oops. Stable branch.

This revision is now accepted and ready to land.Dec 23 2019, 12:24 AM
meven accepted this revision.Dec 23 2019, 1:10 AM

Thanks

broulik added a comment.Dec 23 2019, 10:44 AM

Oops. Stable branch.

I think this refactor is only in master anyway?

Closed by commit R318:151a17e04800: [DolphinContextMenu] Use contains check for scheme again (authored by broulik). · Explain WhyDec 23 2019, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphincontextmenu.cpp (4 lines)

Diff 72060

View Options

src/dolphincontextmenu.cpp

Loading...