[KDocTools] Port QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by ahmadsamir on Dec 22 2019, 5:34 PM.

Details

Reviewers

ltoscano
apol

Group Reviewers

Documentation

Maniphest Tasks

T12279: Port frameworks away from QRegExp

Commits

R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression

Summary

xslt.cpp didn't really use QRegExp as the line using it has been commented
out since 2013, removed now.

Diff Detail

Repository

R238 KDocTools

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahmadsamir created this revision.Dec 22 2019, 5:34 PM

Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptDec 22 2019, 5:34 PM

ahmadsamir requested review of this revision.Dec 22 2019, 5:34 PM

Harbormaster completed remote builds in B20158: Diff 72004.Dec 22 2019, 5:34 PM

LGTM otherwise

src/docbookl10nhelper.cpp
158–161	const all of these?
184–185	Just do `QRegularExpressionMatch match = rxEntity.match(line);`

Make QRegularExpression objects const.

Declare and assign on one line.

Harbormaster completed remote builds in B20175: Diff 72037.Dec 23 2019, 6:25 AM

ahmadsamir marked 2 inline comments as done.Dec 23 2019, 6:26 AM

ahmadsamir added inline comments.

src/docbookl10nhelper.cpp
184–185	I did it that way to indicate match is going to be re-assigned-to later on, but it does look off a bit. :)

apol accepted this revision.Dec 23 2019, 12:50 PM

apol added inline comments.

src/docbookl10nhelper.cpp
184–185	The way of saying it will be re-defined is by not making it const ;).

This revision is now accepted and ready to land.Dec 23 2019, 12:50 PM

Closed by commit R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression (authored by ahmadsamir). · Explain WhyDec 23 2019, 1:17 PM

This revision was automatically updated to reflect the committed changes.

ahmadsamir marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			src/docbookl10nhelper.cpp (37 lines)
M			src/xslt.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72004	bd4905c		Dec 22 2019, 5:34 PM	★	★
Diff 2	72037	bd4905c	Make QRegularExpression objects const.	Dec 23 2019, 6:25 AM	★	★
Diff 3	72080	bd4905c	R238:36fae95175023414fad2a5ea33ae6d77357dd7c2	Dec 23 2019, 1:17 PM	★	★

[KDocTools] Port QRegExp to QRegularExpressionClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 72080

src/docbookl10nhelper.cpp

src/xslt.cpp

[KDocTools] Port QRegExp to QRegularExpression
ClosedPublic
Actions

Revision Contents
Changeset List