Differential D26156

[KDocTools] Port QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by ahmadsamir on Dec 22 2019, 5:34 PM.

Details

Reviewers
ltoscano
apol
Group Reviewers
Documentation
Maniphest Tasks
T12279: Port frameworks away from QRegExp
Commits
R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression
Summary

xslt.cpp didn't really use QRegExp as the line using it has been commented
out since 2013, removed now.

Diff Detail

Repository
R238 KDocTools
Branch
l-qregularexpression (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20158
Build 20176: arc lint + arc unit
ahmadsamir created this revision.Dec 22 2019, 5:34 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptDec 22 2019, 5:34 PM
ahmadsamir requested review of this revision.Dec 22 2019, 5:34 PM
apol added a subscriber: apol.Dec 23 2019, 2:18 AM

LGTM otherwise

src/docbookl10nhelper.cpp
158

const all of these?

184

Just do QRegularExpressionMatch match = rxEntity.match(line);

ahmadsamir updated this revision to Diff 72037.Dec 23 2019, 6:25 AM

Make QRegularExpression objects const.

Declare and assign on one line.

ahmadsamir marked 2 inline comments as done.Dec 23 2019, 6:26 AM
ahmadsamir added inline comments.
src/docbookl10nhelper.cpp
184

I did it that way to indicate match is going to be re-assigned-to later on, but it does look off a bit. :)

apol accepted this revision.Dec 23 2019, 12:50 PM
apol added inline comments.
src/docbookl10nhelper.cpp
184

The way of saying it will be re-defined is by not making it const ;).

This revision is now accepted and ready to land.Dec 23 2019, 12:50 PM
Closed by commit R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression (authored by ahmadsamir). · Explain WhyDec 23 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Msrc/docbookl10nhelper.cpp (38 lines)
Msrc/xslt.cpp (2 lines)

Diff 72004

View Options

src/docbookl10nhelper.cpp

Loading...
View Options

src/xslt.cpp

Loading...