Clean-up DolphinFacetsWidget
ClosedPublic

Authored by iasensio on Dec 21 2019, 7:01 PM.

Details

Summary

Small refactor patch to clean-up some logic on setter and getter:

  • Search terms are previously splitted and set separately, so no need for extra splitting and foreach loop
  • Return search terms on a QStringList rather than join first

Depends on: D26029

Test Plan

No behavior changes

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio requested review of this revision.Dec 21 2019, 7:01 PM
iasensio created this revision.
elvisangelaccio accepted this revision.Dec 28 2019, 6:07 PM

Nice cleanup!

This revision is now accepted and ready to land.Dec 28 2019, 6:07 PM
This revision was automatically updated to reflect the committed changes.