Differential D26029

Rename methods on DolphinFacetsWidget
ClosedPublic
Actions

Authored by iasensio on Dec 15 2019, 10:33 PM.

Tags

Subscribers

Details

Reviewers

elvisangelaccio

Group Reviewers

Commits

R318:732697d0d6fc: Rename methods on DolphinFacetsWidget

Summary

Small refactor patch to rename method names, from ratingTerm to searchTerm,
since its scope has grown bigger.

Test Plan

No behavior changes

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

iasensio created this revision.Dec 15 2019, 10:33 PM

Restricted Application added a project: Dolphin. · View Herald TranscriptDec 15 2019, 10:33 PM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

iasensio requested review of this revision.Dec 15 2019, 10:33 PM

Harbormaster completed remote builds in B19900: Diff 71635.Dec 15 2019, 10:33 PM

Do you mind splitting this into a renaming-only patch and another patch for the changes to the logic?

Only rename methods

Harbormaster completed remote builds in B20134: Diff 71967.Dec 21 2019, 6:50 PM

iasensio retitled this revision from Refactor DolphinFacetsWidget to Rename methods on DolphinFacetsWidget.Dec 21 2019, 6:52 PM

iasensio edited the summary of this revision. (Show Details)

iasensio mentioned this in D26150: Clean-up DolphinFacetsWidget.Dec 21 2019, 7:01 PM

iasensio added a dependent revision: D26150: Clean-up DolphinFacetsWidget.Dec 21 2019, 7:04 PM

elvisangelaccio accepted this revision.Dec 26 2019, 6:06 PM

This revision is now accepted and ready to land.Dec 26 2019, 6:06 PM

Closed by commit R318:732697d0d6fc: Rename methods on DolphinFacetsWidget (authored by iasensio). · Explain WhyDec 26 2019, 6:30 PM

This revision was automatically updated to reflect the committed changes.

iasensio mentioned this in R318:c331d7068574: Clean-up DolphinFacetsWidget.Dec 29 2019, 8:05 PM

Revision Contents
Changeset List

			Path	Packages
M			src/search/dolphinfacetswidget.h (9 lines)
M			src/search/dolphinfacetswidget.cpp (12 lines)
M			src/search/dolphinquery.cpp (2 lines)
M			src/search/dolphinsearchbox.cpp (6 lines)

Diff 72220

src/search/dolphinfacetswidget.h

Loading...

src/search/dolphinfacetswidget.cpp

Loading...

src/search/dolphinquery.cpp

Loading...

src/search/dolphinsearchbox.cpp

Loading...