Improved activity smallnumbers dataset
AbandonedPublic

Authored by jjazeix on Dec 19 2019, 6:47 PM.

Details

Test Plan

new Dataset is as follows:-
7 levels

  • select number on dice upto 3
  • select number on dice upto 4
  • select number on dice upto 5
  • select number on dice upto 6
  • select number on dice upto 7
  • select number on dice upto 8
  • select number on dice upto 9

Each level has several sublevel

  • in first sublevel , cubes with max number of that level fall down ( to teach new number)
  • in rest sublevels , cubes upto max number of that level will fall down( to train)

Everything tested in my system.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
shubhammishra requested review of this revision.Dec 19 2019, 6:47 PM
shubhammishra created this revision.
shubhammishra edited the test plan for this revision. (Show Details)Dec 19 2019, 6:59 PM

I have the following error when I run the activity, only for first level: qml: VirtualKeyboard error: VirtualKeyboard: Invalid layout, array of length > 0
Can you please check why?

src/activities/smallnumbers/resource/7/Data.qml
3

please fix the typo and use same email as last time (in all files and in "Authors" too)

  • fixed typo and edit gletter.js to handle digits too
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 26 2019, 1:07 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jjazeix added inline comments.Dec 26 2019, 1:57 PM
src/activities/gletters/gletters.js
156 ↗(On Diff #72203)

sisUpper -> isUpper?

src/activities/smallnumbers/resource/7/Data.qml
104

remove useless line breaks

jjazeix added inline comments.Dec 26 2019, 2:08 PM
src/activities/smallnumbers/resource/7/Data.qml
27

should be 6

jjazeix added inline comments.Dec 26 2019, 2:11 PM
src/activities/gletters/gletters.js
156 ↗(On Diff #72203)

also, why the updates here and below?

fixed spacing
shubhammishra marked an inline comment as done.EditedDec 26 2019, 2:56 PM

reason for editing gletters.js -
previous code was treating digits and numbers in same way and making shift enable in virtual keyboard for numbers too. so i just added a condition to ensure that letter is alphabet.
in below code while( offset < letters.length-1) will never run if we need to display only one letter in virtual keyboard, this is the reason for prior error of virtual keyboard in level 1.

difficulty for data 7 fixed

reason for editing gletters.js -
previous code was treating digits and numbers in same way and making shift enable in virtual keyboard for numbers too. so i just added a condition to ensure that letter is alphabet.

Can you add a new variable isDigit, it will be easier to understand?

-added isDigit variable in gletters.js

Except the maybe useless import, seems good to me

src/activities/smallnumbers/resource/1/Data.qml
21

I don't think the import of QtQuick and GCompris are necessary, can you remove them?

  • removed unnecessary imports

Tested and I find some pedagogical problems. Lets take the level to learn 9.
We train first 9 in level 1 then we forget about it until level 6.
I would propose the following:

Level1: 9
level 2: 8 to 9
level 3: 7 to 9
level 4: 6 to 9

etc. ....

This way we really train the new number we are learning.

We also have a difficulty problem.
learning
0 to 3: star 1
3 to 5: stars 2
5 to 9: stars 3

What do you think?

I you agree could you update the description of the current ticket, I would then copy paste it in ticket https://phabricator.kde.org/T12428

Could you follow the following presentation in the description?

oal: In a limited time, count or recognise the number of dots
MultipleData1: 1 star
Goal: In a limited time, count or recognise the number of dots from 1 to 3
Level 1: In a limited time, count or recognise the number of dots from 1 to 2
Random dices from 1 to 2
Level 2: In a limited time, count or recognise the number of dots from 1 to 3
Random dices from 1 to 3

MultipleData2: 2 stars
Goal: In a limited time, count or recognise the number of dots from 1 to 4
Level 1: In a limited time, count or recognise the number 4
Dice 4, several times
Level 2: In a limited time, count or recognise the number of dots from 3 to 4
Random dices from 3 to 4
Level 3: In a limited time, count or recognise the number of dots from 2 to 4
Random dices from 2 to 4
Level 4: In a limited time, count or recognise the number of dots from 1 to 4
Random dices from 1 to 4

shubhammishra marked 5 inline comments as done.
  • solved pedagogical problem

I you agree could you update the description of the current ticket, I would then copy paste it in ticket https://phabricator.kde.org/T12428

done

jjazeix commandeered this revision.Jan 19 2020, 5:06 PM
jjazeix abandoned this revision.
jjazeix added a reviewer: shubhammishra.

Changes have been applied in https://phabricator.kde.org/D26539