kcmshell5 componentchooser
Details
Details
- Reviewers
crossi ngraham ervin - Group Reviewers
Plasma - Commits
- R119:967b6ac017e8: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit…
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- component-browser
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20214 Build 20232: arc lint + arc unit
| kcms/componentchooser/componentchooser.cpp | ||
|---|---|---|
| 207 ↗ | (On Diff #72053) | No spaces between the parenthesis, no space after * |
| kcms/componentchooser/componentchooser.h | ||
| 42 ↗ | (On Diff #72053) | Wrong indentation for that file which happens to be non standard Also it's probably best to keep it pure-virtual to avoid the bastardization of something which looks like an interface into an abstract class. |
| 64 ↗ | (On Diff #72053) | ditto |
| 94 ↗ | (On Diff #72053) | ditto |
| kcms/componentchooser/componentchooserbrowser.cpp | ||
| 112 ↗ | (On Diff #72053) | Ref on a temporary sounds fishy to me. |
| kcms/componentchooser/componentchooserbrowser.h | ||
| 31 ↗ | (On Diff #72053) | Wrong indentation |
This comment was removed by meven.