[KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly
ClosedPublic

Authored by meven on Dec 19 2019, 11:21 AM.

Diff Detail

Repository
R119 Plasma Desktop
Branch
component-browser
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20076
Build 20094: arc lint + arc unit
meven created this revision.Dec 19 2019, 11:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 19 2019, 11:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 19 2019, 11:21 AM
meven updated this revision to Diff 71878.Dec 20 2019, 11:00 AM

Better filter web browser to expose to users

some nitpicks, otherwise looks good.

kcms/componentchooser/componentchooser.h
42

Can you make it const please.

kcms/componentchooser/componentchooserbrowser.cpp
110

Did you mean constraints ?

meven updated this revision to Diff 71894.Dec 20 2019, 2:51 PM

const isDefaults, type variable name fix

meven marked 2 inline comments as done.Dec 20 2019, 2:51 PM
meven updated this revision to Diff 72052.Dec 23 2019, 9:57 AM

[KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72053.Dec 23 2019, 9:58 AM

Clean unrelated changes

ervin requested changes to this revision.Dec 23 2019, 12:59 PM
ervin added inline comments.
kcms/componentchooser/componentchooser.cpp
207

No spaces between the parenthesis, no space after *

kcms/componentchooser/componentchooser.h
42

Wrong indentation for that file which happens to be non standard

Also it's probably best to keep it pure-virtual to avoid the bastardization of something which looks like an interface into an abstract class.

64

ditto

94

ditto

kcms/componentchooser/componentchooserbrowser.cpp
112

Ref on a temporary sounds fishy to me.

kcms/componentchooser/componentchooserbrowser.h
31

Wrong indentation

This revision now requires changes to proceed.Dec 23 2019, 12:59 PM
meven updated this revision to Diff 72099.Dec 23 2019, 4:35 PM
meven marked 4 inline comments as done.

Keep isDefaults virtual, fix a fishy ref&, space formatting

meven updated this revision to Diff 72100.Dec 23 2019, 4:37 PM

Space formatting

ervin added a comment.Dec 23 2019, 5:02 PM

Still some broken indentation, the files have weird indentation in that module it seems

kcms/componentchooser/componentchooserterminal.h
33 ↗(On Diff #72100)

broken indentation

kcms/componentchooser/kcm_componentchooser.cpp
40

broken indentation

ervin requested changes to this revision.Dec 26 2019, 2:23 PM
This revision now requires changes to proceed.Dec 26 2019, 2:23 PM
meven updated this revision to Diff 72362.Dec 30 2019, 9:05 AM
meven marked 3 inline comments as done.

Fix indentation issues

meven marked an inline comment as done.Dec 30 2019, 9:05 AM
meven planned changes to this revision.Dec 30 2019, 9:07 AM
This comment was removed by meven.
meven requested review of this revision.Dec 30 2019, 9:09 AM
ervin accepted this revision.Dec 30 2019, 4:50 PM
This revision is now accepted and ready to land.Dec 30 2019, 4:50 PM
This revision was automatically updated to reflect the committed changes.