Use a fixed icon size for the notification popup close button

Authored by ahiemstra on Dec 18 2019, 11:10 PM.



Both the popup header size as well as units.smallMargin depend on font
size. This causes problems with the new circular timeout indicator.
Rather than trying to somehow fix the margins, this patch changes things
to use units.iconSizes.smallMedium as close button icon size instead,
stopping it from relying on font size and hopefully fixing any layout

Test Plan

Change font size to 10/11/12 pt. Icon size remains the same.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 18 2019, 11:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 18 2019, 11:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 18 2019, 11:10 PM
ndavis added a reviewer: VDG.Dec 18 2019, 11:29 PM
ndavis added a subscriber: ndavis.EditedDec 18 2019, 11:38 PM

I think the larger close icon looks nicer and more in line with window decorations:

The offset is still there, unfortunately.

It may just be an optical illusion. Sometimes red next to blue or another highly saturated color will appear to be 1px higher than it actually is.
Here's a white icon:

ndavis accepted this revision.EditedDec 19 2019, 5:56 AM

Actually, it might not even an optical illusion. It might just be because my laptop screen is low quality :(
Sorry for all the fuss

This revision is now accepted and ready to land.Dec 19 2019, 5:56 AM
ngraham accepted this revision.Dec 19 2019, 2:39 PM
This revision was automatically updated to reflect the committed changes.

The icon looks pretty big here now - wouldn't it be small for normal ToolButton icon?