Both the popup header size as well as units.smallMargin depend on font
size. This causes problems with the new circular timeout indicator.
Rather than trying to somehow fix the margins, this patch changes things
to use units.iconSizes.smallMedium as close button icon size instead,
stopping it from relying on font size and hopefully fixing any layout
issues.
Details
Details
- Reviewers
ndavis ngraham - Group Reviewers
Plasma VDG - Commits
- R120:66aaaf72a4df: Use a fixed icon size for the notification popup close button
Change font size to 10/11/12 pt. Icon size remains the same.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- notification_close_size
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20037 Build 20055: arc lint + arc unit
Comment Actions
The offset is still there, unfortunately.
I think the larger close icon looks nicer and more in line with window decorations:
The offset is still there, unfortunately.
Comment Actions
It may just be an optical illusion. Sometimes red next to blue or another highly saturated color will appear to be 1px higher than it actually is.
Here's a white icon:
Comment Actions
Actually, it might not even an optical illusion. It might just be because my laptop screen is low quality :(
Sorry for all the fuss
Comment Actions
The icon looks pretty big here now - wouldn't it be small for normal ToolButton icon?
The icon looks pretty big here now - wouldn't it be small for normal ToolButton icon?