Differential D26029

Rename methods on DolphinFacetsWidget
ClosedPublic
Actions

Authored by iasensio on Dec 15 2019, 10:33 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:732697d0d6fc: Rename methods on DolphinFacetsWidget
Summary

Small refactor patch to rename method names, from ratingTerm to searchTerm,
since its scope has grown bigger.

Test Plan

No behavior changes

Diff Detail

Repository
R318 Dolphin
Branch
facets_rename
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20134
Build 20152: arc lint + arc unit
iasensio created this revision.Dec 15 2019, 10:33 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 15 2019, 10:33 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Dec 15 2019, 10:33 PM
elvisangelaccio added a comment.Dec 21 2019, 6:04 PM

Do you mind splitting this into a renaming-only patch and another patch for the changes to the logic?

iasensio updated this revision to Diff 71967.Dec 21 2019, 6:50 PM
  • Only rename methods
iasensio retitled this revision from Refactor DolphinFacetsWidget to Rename methods on DolphinFacetsWidget.Dec 21 2019, 6:52 PM
iasensio edited the summary of this revision. (Show Details)
elvisangelaccio accepted this revision.Dec 26 2019, 6:06 PM
This revision is now accepted and ready to land.Dec 26 2019, 6:06 PM
Closed by commit R318:732697d0d6fc: Rename methods on DolphinFacetsWidget (authored by iasensio). · Explain WhyDec 26 2019, 6:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71967

View Options

src/search/dolphinfacetswidget.h

Loading...
View Options

src/search/dolphinfacetswidget.cpp

Loading...
View Options

src/search/dolphinquery.cpp

Loading...
View Options

src/search/dolphinsearchbox.cpp

Loading...