Differential D26017

[KKeySequenceWidget] Work around Meta modifier behavior
ClosedPublic
Actions

Authored by broulik on Dec 15 2019, 1:25 PM.

Details

Reviewers
davidedmundson
ahartmetz
Group Reviewers
Frameworks
Commits
R263:577e8cddde7d: [KKeySequenceWidget] Work around Meta modifier behavior
Summary

When I press my Meta key, I get a Key_Super_L *without* a Meta key confusing the rest of the modifier handling in this class.
To work around this, explicitly set MetaModifier when the key is pressed and remove it

Test Plan
  • I can now press Meta and it is handled immediately like Alt and Shift

Diff Detail

Repository
R263 KXmlGui
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 15 2019, 1:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 15 2019, 1:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Dec 15 2019, 1:25 PM
davidedmundson accepted this revision.Dec 15 2019, 3:26 PM
This revision is now accepted and ready to land.Dec 15 2019, 3:26 PM
Closed by commit R263:577e8cddde7d: [KKeySequenceWidget] Work around Meta modifier behavior (authored by broulik). · Explain WhyApr 9 2020, 1:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kkeysequencewidget.cpp (11 lines)

Diff 71597

View Options

src/kkeysequencewidget.cpp

Loading...