Differential D25996

KRemoteEncoding::encoding: don't return temporary. Found with clazy.
ClosedPublic
Actions

Authored by chehrlic on Dec 14 2019, 4:32 PM.

Details

Reviewers
thiago
dfaure
Commits
R241:d80cb8c96eef: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

Diff Detail

Repository
R241 KIO
Branch
remoteencoding
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19843
Build 19861: arc lint + arc unit
chehrlic created this revision.Dec 14 2019, 4:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 14 2019, 4:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
chehrlic requested review of this revision.Dec 14 2019, 4:32 PM
thiago added a comment.Dec 14 2019, 5:36 PM

Good catch.

chehrlic added a comment.Dec 14 2019, 5:39 PM

It was clazy, not me - just wanted to fix a memleak in kio :)

dfaure accepted this revision.Dec 14 2019, 9:06 PM
This revision is now accepted and ready to land.Dec 14 2019, 9:06 PM
Closed by commit R241:d80cb8c96eef: KRemoteEncoding::encoding: don't return temporary. Found with clazy. (authored by chehrlic). · Explain WhyDec 15 2019, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/kremoteencoding.cpp (4 lines)

Diff 71529

View Options

src/core/kremoteencoding.cpp

Loading...