Home
Phabricator
Search
Log In
Differential
D25996
KRemoteEncoding::encoding: don't return temporary. Found with clazy.
Closed
Public
Actions
Authored by
chehrlic
on Dec 14 2019, 4:32 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
Frameworks
Subscribers
kde-frameworks-devel
Details
Reviewers
thiago
dfaure
Commits
R241:d80cb8c96eef: KRemoteEncoding::encoding: don't return temporary. Found with clazy.
Diff Detail
Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chehrlic
created this revision.
Dec 14 2019, 4:32 PM
Restricted Application
added a project:
Frameworks
.
·
View Herald Transcript
Dec 14 2019, 4:32 PM
Restricted Application
added a subscriber:
kde-frameworks-devel
.
·
View Herald Transcript
chehrlic
requested review of this revision.
Dec 14 2019, 4:32 PM
Harbormaster
completed remote builds in
B19843: Diff 71529
.
Dec 14 2019, 4:32 PM
chehrlic
added reviewers:
thiago
,
dfaure
.
Dec 14 2019, 4:35 PM
thiago
added a comment.
Dec 14 2019, 5:36 PM
Comment Actions
Good catch.
chehrlic
added a comment.
Dec 14 2019, 5:39 PM
Comment Actions
It was clazy, not me - just wanted to fix a memleak in kio :)
dfaure
accepted this revision.
Dec 14 2019, 9:06 PM
This revision is now accepted and ready to land.
Dec 14 2019, 9:06 PM
Closed by commit
R241:d80cb8c96eef: KRemoteEncoding::encoding: don't return temporary. Found with clazy.
(authored by
chehrlic
).
·
Explain Why
Dec 15 2019, 9:46 AM
This revision was automatically updated to reflect the committed changes.