Don't overload the word "Properties" to mean multiple things
ClosedPublic

Authored by ngraham on Dec 14 2019, 1:19 PM.

Details

Summary

Generally "Properties" refers to information about a selected file. However Dolphin also
uses the word "Properties" in the phrase "View Properties", which refers to the display
style of the view. Since "properties" is a fairly esoteric and technical term to most
users, it would probably be wise to avoid using it in multiple contexts.

Accordingly, this patch changes "view properties" to "view display style".

Test Plan

Look at the settings window, hamburger menu, view menu, and docbook

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Dec 14 2019, 1:19 PM
Restricted Application added projects: Dolphin, Documentation. · View Herald TranscriptDec 14 2019, 1:19 PM
Restricted Application added subscribers: kde-doc-english, kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 14 2019, 1:19 PM
ndavis accepted this revision.Dec 15 2019, 1:58 AM
ndavis added a subscriber: ndavis.

Makes sense to me.

This revision is now accepted and ready to land.Dec 15 2019, 1:58 AM
elvisangelaccio accepted this revision.Dec 15 2019, 1:07 PM
This revision was automatically updated to reflect the committed changes.
meven added a subscriber: meven.Dec 17 2019, 7:41 AM
meven added inline comments.
src/settings/viewpropertiesdialog.cpp
51

It'd be great to rename the related class and files accordingly to avoid having a naming gap between devs and users.

Good idea, I'll do that next.