Previously, the code checked for years by checking for length 4. However this resulted in dates with single digit hours, e.g. 9:37, being interpreted as years. Thus, it would parse the hour as a year, in this case making it year 9. Now it instead checks for years by checking whether there's a colon.
Details
Details
- Reviewers
dfaure sitter feverfew - Group Reviewers
Frameworks - Commits
- R241:fca8cb47d831: Ftp ioslave: fix 4 character time interpreted as year
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks correct (given the if() further down, not visible in this context-less patch).
Do you have commit access, or do you need someone to land this?
[I wish this parsing code was in a separate class so it could be unittested separately...]
Comment Actions
I learned recently that you can find out if someone has commit rights by doing a find on https://websvn.kde.org/trunk/kde-common/accounts?view=markup.
Looks like no in this case. @linagkar, can we have your email address so we can land the patch with correct authorship information? Thanks!