When using a dark theme, plain text files without an associated highlighting theme are rendered in white on a white background (see also bugs 409380 and 406821). This patch forces a re-highlighting of the preview after the theme is set and before it is drawn into the preview area.
Details
Details
- Reviewers
anthonyfieroni - Group Reviewers
Dolphin - Commits
- R320:4ec12a850e25: fix preview of plain text files when using dark theme
opened dolphin, checked several text files for correct preview colors
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
performance improvement: only do one round of highlighting (skip the one run in the constructor of QSyntaxHighlighter)
Comment Actions
For reference I had a similar patch https://phabricator.kde.org/D25323 and a potential fix in KSyntaxHighlighting https://phabricator.kde.org/D25328