Differential D25811

cmake: Fix `CMAKE_POLICY_*_CMP<N>` regex and add special args to `get_cmake_property`
ClosedPublic
Actions

Authored by turbov on Dec 8 2019, 3:03 PM.

Details

Reviewers
cullmann
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:bb06250bd2a5: cmake: Fix `CMAKE_POLICY_*_CMP<N>` regex and add special args to…

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
turbov created this revision.Dec 8 2019, 3:03 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 8 2019, 3:03 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
turbov requested review of this revision.Dec 8 2019, 3:03 PM
cullmann added a subscriber: cullmann.Dec 8 2019, 3:09 PM

Nice that you take care of that stuff.
Could you enhance the CMake test file, too, to cover some of the new stuff?

cullmann added a comment.Jan 4 2020, 4:53 PM

Hi, can you add stuff to the tests or shall we merge this as is?

turbov added a comment.Jan 6 2020, 1:43 PM
In D25811#587606, @cullmann wrote:

Hi, can you add stuff to the tests or shall we merge this as is?

Sorry, I don't have time for this nowadays %(

cullmann added a comment.Jan 6 2020, 1:50 PM

Ok, then let's merge as is.
Thanks for the improvement (+ happy new year).

cullmann accepted this revision.Jan 6 2020, 1:50 PM
This revision is now accepted and ready to land.Jan 6 2020, 1:50 PM
Closed by commit R216:bb06250bd2a5: cmake: Fix `CMAKE_POLICY_*_CMP<N>` regex and add special args to… (authored by cullmann). · Explain WhyJan 14 2020, 11:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71088

View Options

data/generators/cmake.xml.tpl

Loading...
View Options

data/generators/cmake.yaml

Loading...
View Options

data/generators/generate-cmake-syntax.py

Loading...
View Options

data/syntax/cmake.xml

Loading...