Differential D25788

Initialise QML monitor values
ClosedPublic
Actions

Authored by davidedmundson on Dec 6 2019, 4:33 PM.

Details

Reviewers
ngraham
Commits
R293:a9dff763bf39: Initialise QML monitor values
Summary

m_indexerState would not be initialised and m_totalFiles would be
garbage values if baloo_file wasn't running. We want to initialise
everything.

Test Plan

Compiles

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19553
Build 19571: arc lint + arc unit
davidedmundson created this revision.Dec 6 2019, 4:33 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 6 2019, 4:33 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 6 2019, 4:33 PM
ngraham accepted this revision.Dec 6 2019, 5:33 PM
This revision is now accepted and ready to land.Dec 6 2019, 5:33 PM
Closed by commit R293:a9dff763bf39: Initialise QML monitor values (authored by davidedmundson). · Explain WhyDec 18 2019, 10:03 AM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Dec 18 2019, 10:17 AM
broulik added inline comments.
src/qml/experimental/monitor.h
82

Might was well move the nullptr here, too

Revision Contents
Changeset List

Diff 71023

View Options

src/qml/experimental/monitor.h

Loading...
View Options

src/qml/experimental/monitor.cpp

Loading...