[KHistoryComboBox] Add method to set an icon provider
ClosedPublic

Authored by nicolasfella on Mon, Dec 2, 10:52 PM.

Details

Summary

An icon provider can be any function that takes a QString and returns a QIcon. This shall replace the setPixmapProvider to allow defining icons by name.

Test Plan

Tested with KDirSelectDialog and a patched plasma-integration

Diff Detail

Repository
R284 KCompletion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mon, Dec 2, 10:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Dec 2, 10:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mon, Dec 2, 10:52 PM
  • Deprecation, fix, and docs
nicolasfella edited the summary of this revision. (Show Details)Mon, Dec 2, 11:12 PM
apol added a subscriber: apol.Mon, Dec 2, 11:48 PM

+1 Makes sense to me

nicolasfella updated this revision to Diff 71070.EditedSat, Dec 7, 10:49 PM

Rebase

  • Adapt deprecation version
dfaure requested changes to this revision.Sun, Dec 8, 10:31 PM
dfaure added inline comments.
src/khistorycombobox.cpp
415

s/ENABLE/BUILD/ in .cpp files

499

BUILD

src/khistorycombobox.h
195

Missing @since 5.66

This revision now requires changes to proceed.Sun, Dec 8, 10:31 PM
nicolasfella marked 3 inline comments as done.
  • Comments
dfaure accepted this revision.Sun, Dec 8, 10:59 PM
This revision is now accepted and ready to land.Sun, Dec 8, 10:59 PM
This revision was automatically updated to reflect the committed changes.