Differential D25701

Use setIconProvider instead of setPixmapProvider for KHistoryComboBox
ClosedPublic
Actions

Authored by nicolasfella on Dec 2 2019, 11:00 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Frameworks
Maniphest Tasks
T12310: Kill KUrlPixmapProvider and KPixmapProvider
Commits
R135:a5bdd39f9355: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox
Summary

setPixmapProvider will be deprecated with D25700

Test Plan

Open open folder dialog, history combobox still has icons

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 2 2019, 11:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 2 2019, 11:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 2 2019, 11:00 PM
apol accepted this revision.Dec 2 2019, 11:47 PM
This revision is now accepted and ready to land.Dec 2 2019, 11:47 PM
nicolasfella added a comment.Dec 8 2019, 11:04 PM

Can Plasma depend on Frameworks master or does this have to wait until 5.66 release?

apol added a comment.Dec 9 2019, 2:24 AM

Plasma master can depend on kf5 master.

Closed by commit R135:a5bdd39f9355: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox (authored by nicolasfella). · Explain WhyDec 9 2019, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71120

View Options

src/platformtheme/kdirselectdialog.cpp

Loading...