Differential D25650

Port foreach
ClosedPublic
Actions

Authored by nicolasfella on Dec 1 2019, 1:08 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R263:6ba0d9371f74: Port foreach
Test Plan

Builds, tests pass, dolphin opens

Diff Detail

Repository
R263 KXmlGui
Branch
fore
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19334
Build 19352: arc lint + arc unit
nicolasfella created this revision.Dec 1 2019, 1:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 1 2019, 1:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 1 2019, 1:08 PM
apol accepted this revision.Dec 1 2019, 5:15 PM
apol added a subscriber: apol.
apol added inline comments.
CMakeLists.txt
72

This comment looks wrong

This revision is now accepted and ready to land.Dec 1 2019, 5:15 PM
Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella). · Explain WhyDec 1 2019, 5:17 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella marked an inline comment as done.Dec 1 2019, 5:18 PM
nicolasfella added inline comments.
CMakeLists.txt
72

Fixed

Revision Contents
Changeset List

Diff 70664

View Options

CMakeLists.txt

Loading...
View Options

src/kaboutapplicationpersonlistdelegate_p.cpp

Loading...
View Options

src/kkeysequencewidget.cpp

Loading...
View Options

src/kmainwindow.cpp

Loading...
View Options

src/ktoolbar.cpp

Loading...
View Options

src/ktoolbarhandler.cpp

Loading...
View Options

src/kxmlguifactory.cpp

Loading...
View Options

src/kxmlguifactory_p.cpp

Loading...