Differential D25650

Port foreach
ClosedPublic
Actions

Authored by nicolasfella on Dec 1 2019, 1:08 PM.

Tags

Subscribers

apol, kde-frameworks-devel

Details

Reviewers

Group Reviewers

Commits

R263:6ba0d9371f74: Port foreach

Test Plan

Builds, tests pass, dolphin opens

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Dec 1 2019, 1:08 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 1 2019, 1:08 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Dec 1 2019, 1:08 PM

Harbormaster completed remote builds in B19334: Diff 70664.Dec 1 2019, 1:08 PM

apol accepted this revision.Dec 1 2019, 5:15 PM

apol added a subscriber: apol.

apol added inline comments.

CMakeLists.txt
71	This comment looks wrong

This revision is now accepted and ready to land.Dec 1 2019, 5:15 PM

Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella). · Explain WhyDec 1 2019, 5:17 PM

This revision was automatically updated to reflect the committed changes.

nicolasfella marked an inline comment as done.Dec 1 2019, 5:18 PM

nicolasfella added inline comments.

CMakeLists.txt
71	Fixed

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			src/kaboutapplicationpersonlistdelegate_p.cpp (3 lines)
M			src/kkeysequencewidget.cpp (2 lines)
M			src/kmainwindow.cpp (3 lines)
M			src/ktoolbar.cpp (2 lines)
M			src/ktoolbarhandler.cpp (2 lines)
M			src/kxmlguifactory.cpp (2 lines)
M			src/kxmlguifactory_p.cpp (4 lines)

Diff 70682

CMakeLists.txt

Loading...

src/kaboutapplicationpersonlistdelegate_p.cpp

Loading...

src/kkeysequencewidget.cpp

Loading...

src/kmainwindow.cpp

Loading...

src/ktoolbar.cpp

Loading...

src/ktoolbarhandler.cpp

Loading...

src/kxmlguifactory.cpp

Loading...

src/kxmlguifactory_p.cpp

Loading...