Differential D25638

autotests: Find perl executable on all platforms
ClosedPublic
Actions

Authored by aspotashev on Nov 30 2019, 7:09 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R172:accdbdd65ee0: autotests: Find perl executable on all platforms
Summary

Attempt to fix unit tests on FreeBSD.

Test Plan

Unit tests are able to run Perl script on Linux. (Would be better to test this on all platforms, but I can't do that easily.)

Diff Detail

Repository
R172 KCalendar Core
Branch
perl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19316
Build 19334: arc lint + arc unit
aspotashev created this revision.Nov 30 2019, 7:09 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 30 2019, 7:09 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
aspotashev requested review of this revision.Nov 30 2019, 7:09 PM
aspotashev added a reviewer: Frameworks.Nov 30 2019, 7:10 PM
aspotashev added a project: Frameworks.
aspotashev added a subscriber: Frameworks.
apol added a subscriber: apol.Nov 30 2019, 7:51 PM
apol added inline comments.
autotests/CMakeLists.txt
93

maybe it would make sense to check for BSD instead?
I don't know much about BSD, but I'd expect the shebang to work there as well.

aspotashev added inline comments.Dec 1 2019, 9:30 AM
autotests/CMakeLists.txt
93

I think it's better to minimize platform-specific if-endifs and make CMake code clean rather than micro-optimize per platform.

dfaure accepted this revision.Dec 1 2019, 12:14 PM
dfaure added a subscriber: dfaure.

I approve, given that I wrote the same in D25643 :-)

This revision is now accepted and ready to land.Dec 1 2019, 12:14 PM
Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all platforms (authored by aspotashev). · Explain WhyDec 1 2019, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/CMakeLists.txt (9 lines)

Diff 70636

View Options

autotests/CMakeLists.txt

Loading...