Fix EcmGenerateExportHeader tests on Windows
ClosedPublic

Authored by davidre on Sat, Nov 30, 12:18 PM.

Details

Summary

-weXXXX errors on warning XXXX. C4996 warns on deprecated declarations.

Test Plan

Tests pass.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Sat, Nov 30, 12:18 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptSat, Nov 30, 12:18 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Sat, Nov 30, 12:18 PM
davidre retitled this revision from Fix EcmGenerateExportHeader tests on windows to Fix EcmGenerateExportHeader tests on Windows.Sat, Nov 30, 12:22 PM
kossebau accepted this revision.Sat, Nov 30, 12:22 PM

Yay, thanks for fixing this. Not sure if if(MSVC) is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark side now and then. :)
Otherwise +1 for this.

This revision is now accepted and ready to land.Sat, Nov 30, 12:22 PM

Yay, thanks for fixing this. Not sure if if(MSVC) is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark side now and then. :)
Otherwise +1 for this.

I used it because it is the same condition inside ECMGenerateExportHeader.cmake which enables __declspec(deprecated(text)).

This revision was automatically updated to reflect the committed changes.