Differential D25615

Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext
ClosedPublic
Actions

Authored by meven on Nov 29 2019, 5:00 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:8b0c12a59ccb: Refactoring to reduce size of openItemContextMenu and add the ContextType…

Diff Detail

Repository
R318 Dolphin
Branch
refator-context-menu
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19335
Build 19353: arc lint + arc unit
meven created this revision.Nov 29 2019, 5:00 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 29 2019, 5:00 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Nov 29 2019, 5:00 PM
elvisangelaccio added inline comments.Dec 1 2019, 11:16 AM
src/dolphincontextmenu.cpp
209

Why this change?

src/dolphincontextmenu.h
150

I'd prefer to add separate TimelineContext and SearchContext values. It would be more future-proof.

meven updated this revision to Diff 70665.Dec 1 2019, 1:08 PM

Split separately timelinecontext and searchcontext

meven marked 2 inline comments as done.Dec 1 2019, 1:09 PM
meven added inline comments.
src/dolphincontextmenu.cpp
209

The other function is deprecated since KF 5.0

elvisangelaccio accepted this revision.Dec 1 2019, 10:17 PM
This revision is now accepted and ready to land.Dec 1 2019, 10:17 PM
Closed by commit R318:8b0c12a59ccb: Refactoring to reduce size of openItemContextMenu and add the ContextType… (authored by meven). · Explain WhyDec 2 2019, 12:25 PM
This revision was automatically updated to reflect the committed changes.
meven marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Msrc/dolphincontextmenu.h (6 lines)
Msrc/dolphincontextmenu.cpp (67 lines)

Diff 70665

View Options

src/dolphincontextmenu.h

Loading...
View Options

src/dolphincontextmenu.cpp

Loading...