Differential D25582

[kcmkwin/kwindecoration] Better presentation of tabs
ClosedPublic
Actions

Authored by filipf on Nov 27 2019, 11:48 PM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
KWin
VDG
Commits
R108:fd69924e5153: [kcmkwin/kwindecoration] Better presentation of tabs
Summary

Tabs in the Window Decoration KCM look awkward now because the frame is drawing an extra line while the tab bar is also drawing its line.

This patch just slightly alters an existing hack so that the frame's top line can't be seen.

Test Plan

Before:

After:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Nov 27 2019, 11:48 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 27 2019, 11:48 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
filipf requested review of this revision.Nov 27 2019, 11:48 PM
filipf edited the test plan for this revision. (Show Details)Nov 27 2019, 11:49 PM
filipf added reviewers: KWin, VDG.
filipf added a comment.Nov 27 2019, 11:53 PM

P.S what would make this perfect is removing the border in the qqc2 styling of tabbars.

davidedmundson accepted this revision.Nov 27 2019, 11:58 PM
This revision is now accepted and ready to land.Nov 27 2019, 11:58 PM
ngraham added a subscriber: ngraham.Nov 28 2019, 12:01 AM

A saner hack indeed. Probably 5.17-worthy. Can you apply the same thing to the plasma-pa KCM, if it also needs it?

ngraham accepted this revision.Nov 28 2019, 12:02 AM
filipf added a comment.Nov 28 2019, 12:13 AM
In D25582#568654, @ngraham wrote:

A saner hack indeed. Probably 5.17-worthy. Can you apply the same thing to the plasma-pa KCM, if it also needs it?

I actually saw that everything is alright there and then copied the hack's implementation here :)

Closed by commit R108:fd69924e5153: [kcmkwin/kwindecoration] Better presentation of tabs (authored by filipf). · Explain WhyNov 28 2019, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70523

View Options

kcmkwin/kwindecoration/package/contents/ui/main.qml

Loading...