It is not needed since Qt 5.10
Details
Details
- Reviewers
kossebau dfaure davidedmundson - Maniphest Tasks
- T12269: Remove KRecursiveFilterProxyModel
- Commits
- R275:68f3b292ca03: Deprecate KRecursiveFilterProxyModel
Diff Detail
Diff Detail
- Repository
- R275 KItemModels
- Branch
- deprecate (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19215 Build 19233: arc lint + arc unit
Comment Actions
Looks good, besides nitpicks :)
src/core/krecursivefilterproxymodel.cpp | ||
---|---|---|
22 ↗ | (On Diff #70348) | This should be KITEMMODELS_BUILD_DEPRECATED_SINCE (BUILD., not ENABLE) |
src/core/krecursivefilterproxymodel.h | ||
28 ↗ | (On Diff #70348) | Being a duplicate now, this include can be removed. |
93 ↗ | (On Diff #70348) | Perhaps refer to above related comments as well. |
102 ↗ | (On Diff #70348) | More helpful would be perhaps "Use QSortFilterProxyModel directly and QSortFilterProxyModel::setRecursiveFilteringEnabled(true)" |