Deprecate KRecursiveFilterProxyModel
ClosedPublic

Authored by davidre on Tue, Nov 26, 1:59 PM.

Diff Detail

Repository
R275 KItemModels
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Tue, Nov 26, 1:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Nov 26, 1:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Tue, Nov 26, 1:59 PM
davidedmundson accepted this revision.Tue, Nov 26, 2:05 PM
This revision is now accepted and ready to land.Tue, Nov 26, 2:05 PM

Looks good, besides nitpicks :)

src/core/krecursivefilterproxymodel.cpp
22

This should be KITEMMODELS_BUILD_DEPRECATED_SINCE (BUILD., not ENABLE)

src/core/krecursivefilterproxymodel.h
23

Being a duplicate now, this include can be removed.

91

Perhaps refer to above related comments as well.

100

More helpful would be perhaps "Use QSortFilterProxyModel directly and QSortFilterProxyModel::setRecursiveFilteringEnabled(true)"

davidre updated this revision to Diff 70426.Wed, Nov 27, 12:57 PM
davidre marked 4 inline comments as done.

address comments

dfaure accepted this revision.Wed, Nov 27, 5:54 PM
This revision was automatically updated to reflect the committed changes.