Porting away from NetAccess, step 1: code refactoring

Authored by dfaure on Nov 22 2019, 6:50 PM.


  • Split out the NetAccess::exists call from isFromExistingURL(bool),

only one caller was passing true (the default value). Simpler to
remove that bool and call both methods in that one location.

  • Provide a urlExists() method to wrap the calls to NetAccess::exists

and call it from as many places as possible.

Test Plan

Builds, I can open and save a file, but it would take time to figure
out how to trigger all the changed code paths.

Diff Detail

R374 KolourPaint
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Nov 22 2019, 6:50 PM
dfaure created this revision.
vkrause accepted this revision.Nov 27 2019, 5:53 PM
This revision is now accepted and ready to land.Nov 27 2019, 5:53 PM
This revision was automatically updated to reflect the committed changes.