Porting away from NetAccess, step 1: code refactoring
ClosedPublic

Authored by dfaure on Nov 22 2019, 6:50 PM.

Details

Summary
  • Split out the NetAccess::exists call from isFromExistingURL(bool),

only one caller was passing true (the default value). Simpler to
remove that bool and call both methods in that one location.

  • Provide a urlExists() method to wrap the calls to NetAccess::exists

and call it from as many places as possible.

Test Plan

Builds, I can open and save a file, but it would take time to figure
out how to trigger all the changed code paths.

Diff Detail

Repository
R374 KolourPaint
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19064
Build 19082: arc lint + arc unit
dfaure requested review of this revision.Nov 22 2019, 6:50 PM
dfaure created this revision.
vkrause accepted this revision.Nov 27 2019, 5:53 PM
This revision is now accepted and ready to land.Nov 27 2019, 5:53 PM
This revision was automatically updated to reflect the committed changes.