[KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now
ClosedPublic
Actions

Authored by ngraham on Nov 21 2019, 10:03 PM.

Details

Reviewers

mart
cfeck

Group Reviewers

Frameworks

Commits

R295:0ca212481fab: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog…

Summary

See D25444

Depends on D25444

Test Plan

See test plan in D25444

Diff Detail

Repository

R295 KCMUtils

Branch

fix-margins (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19041
Build 19059: arc lint + arc unit

ngraham created this revision.Nov 21 2019, 10:03 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 21 2019, 10:03 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Nov 21 2019, 10:03 PM

Harbormaster completed remote builds in B19041: Diff 70129.Nov 21 2019, 10:03 PM

ngraham mentioned this in D25444: Unify KPageDialog margin handling into KPageDialog itself.Nov 21 2019, 10:05 PM

ngraham edited the summary of this revision. (Show Details)

ngraham added a dependency: D25444: Unify KPageDialog margin handling into KPageDialog itself.

mart accepted this revision.Nov 29 2019, 2:15 PM

This revision is now accepted and ready to land.Nov 29 2019, 2:15 PM

Closed by commit R295:0ca212481fab: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog… (authored by ngraham). · Explain WhyNov 29 2019, 2:27 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in R236:969ec7f2e964: Unify KPageDialog margin handling into KPageDialog itself.

Revision Contents
Changeset List

			Path	Packages
M			src/kcmultidialog.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70129	afc528c		Nov 21 2019, 10:03 PM	★	★
Diff 2	70571	1686782	R295:0ca212481fabbe2499c3442dd58776604d00a178	Nov 29 2019, 2:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
859fdb894411	30ba980e09c5	afc528cf9859	Nate Graham	[KCMultiDialog] Remove most special margins handling; it's done in KPageDialog… (Show More…)	Nov 21 2019, 10:03 PM

	Status	Author	Revision
	Closed	ngraham	D25451 [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now
	Closed	ngraham	D25444 Unify KPageDialog margin handling into KPageDialog itself

Diff 70129

View Options

[KCMultiDialog] Remove most special margins handling; it's done in KPageDialog nowClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 70129

src/kcmultidialog.cpp

[KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now
ClosedPublic
Actions

Revision Contents
Changeset List