This prevents us from having to manually specify the margins in all of the subclasses.
BUG: 413181
FIXED-IN: 5.65
Details
Details
- Reviewers
cfeck mart - Group Reviewers
Frameworks - Commits
- R236:969ec7f2e964: Unify KPageDialog margin handling into KPageDialog itself
Assistant dialog now has correct margins:
App settings window still has correct margins:
After applying D25451, Multi-KCM KCMShell dialog still has correct margins:
After applying D25451, single-KCM KCMShell dialog still has correct margins:
Please test extensively; this code seems somewhat fragile.
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Branch
- fix-assistant-dialog-margins (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19040 Build 19058: arc lint + arc unit
| src/kassistantdialog.cpp | ||
|---|---|---|
| 102 ↗ | (On Diff #70118) | Ideally q->pageWidget()->style() would be cached, given we are in hotpath here during startup, also helps codereading a bit. |
Comment Actions
Since KAssistantDialog is a KPageDialog, what happens to other users of that class? I had hoped the fix is in KPageDialog, and it would only omit the margins when the caller requested it (e.g. KCMs etc.).
| src/kassistantdialog.cpp | ||
|---|---|---|
| 103 ↗ | (On Diff #70118) | Please also pass styleOptions and widget. Some styles might compute margins from font sizes, and without any context, they can only assume defaults. |