fix layout of overlaysheet
ClosedPublic

Authored by mart on Wed, Nov 20, 8:11 PM.

Details

Summary

makes the overlaysheet howit's supposed to be rendered:
since it's "global" in the app, it should be parented to the
applicationwindow overlay, and have a "non 100%" width, but something
based upon readability

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Wed, Nov 20, 8:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Nov 20, 8:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Wed, Nov 20, 8:11 PM
mart edited the test plan for this revision. (Show Details)Wed, Nov 20, 8:12 PM
mart added a reviewer: Discover Software Store.
ngraham added inline comments.
discover/qml/ProgressView.qml
60

Needed?

apol accepted this revision.Thu, Nov 21, 3:14 PM
apol added a subscriber: apol.

Change looks good to me. Please resolve the comments before landing.

libdiscover/backends/DummyBackend/DummyTransaction.cpp
52 ↗(On Diff #70081)

Please don't change this because this will make tests much slower.

This revision is now accepted and ready to land.Thu, Nov 21, 3:14 PM
mart updated this revision to Diff 70335.Tue, Nov 26, 10:32 AM
mart marked 2 inline comments as done.
  • adress comments
This revision was automatically updated to reflect the committed changes.