makes the overlaysheet howit's supposed to be rendered:
since it's "global" in the app, it should be parented to the
applicationwindow overlay, and have a "non 100%" width, but something
based upon readability
Details
Details
- Reviewers
apol - Group Reviewers
Discover Software Store - Commits
- R134:36bf9e7a51fe: fix layout of overlaysheet
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Branch
- phab/overlaysheet
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19169 Build 19187: arc lint + arc unit
discover/qml/ProgressView.qml | ||
---|---|---|
60 | Needed? |
Comment Actions
Change looks good to me. Please resolve the comments before landing.
libdiscover/backends/DummyBackend/DummyTransaction.cpp | ||
---|---|---|
52 ↗ | (On Diff #70081) | Please don't change this because this will make tests much slower. |