Differential D25430

fix layout of overlaysheet
ClosedPublic
Actions

Authored by mart on Nov 20 2019, 8:11 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Commits
R134:36bf9e7a51fe: fix layout of overlaysheet
Summary

makes the overlaysheet howit's supposed to be rendered:
since it's "global" in the app, it should be parented to the
applicationwindow overlay, and have a "non 100%" width, but something
based upon readability

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Branch
phab/overlaysheet
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19004
Build 19022: arc lint + arc unit
mart created this revision.Nov 20 2019, 8:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 20 2019, 8:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 20 2019, 8:11 PM
mart edited the test plan for this revision. (Show Details)Nov 20 2019, 8:12 PM
mart added a reviewer: Discover Software Store.
ngraham added a subscriber: ngraham.Nov 20 2019, 9:44 PM
ngraham added inline comments.
discover/qml/ProgressView.qml
60

Needed?

apol accepted this revision.Nov 21 2019, 3:14 PM
apol added a subscriber: apol.

Change looks good to me. Please resolve the comments before landing.

libdiscover/backends/DummyBackend/DummyTransaction.cpp
52

Please don't change this because this will make tests much slower.

This revision is now accepted and ready to land.Nov 21 2019, 3:14 PM
mart updated this revision to Diff 70335.Nov 26 2019, 10:32 AM
mart marked 2 inline comments as done.
  • adress comments
Closed by commit R134:36bf9e7a51fe: fix layout of overlaysheet (authored by mart). · Explain WhyNov 26 2019, 10:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70081

View Options

discover/qml/ProgressView.qml

Loading...
View Options

libdiscover/backends/DummyBackend/DummyTransaction.cpp

Loading...