Differential D25402

[KDirOperator] Add Backspace shortcut to back action
ClosedPublic
Actions

Authored by meven on Nov 19 2019, 2:42 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Frameworks
Commits
R241:9550ad88a995: [KDirOperator] Add Backspace shortcut to back action
Summary

Very useful when navigating with keyboard in the KDirOperator

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Nov 19 2019, 2:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 19 2019, 2:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Nov 19 2019, 2:42 PM
ngraham added a comment.Nov 20 2019, 6:09 PM

Generally this key is used for "Back," not "Up." If we do this, it will be inconsistent with Dolphin. Maybe we should just match Dolphin's behavior.

meven added a comment.Nov 20 2019, 6:40 PM
In D25402#565326, @ngraham wrote:

Generally this key is used for "Back," not "Up." If we do this, it will be inconsistent with Dolphin. Maybe we should just match Dolphin's behavior.

Nice to know, wasn't aware.
The back action has no shortcut currently, I will change this shortcut to this one.

I have another thing in mind to improve keyboard navigation in KFileWidget.

Btw There is a bug around the ability to change the shortcut in dolphin https://bugs.kde.org/show_bug.cgi?id=371130

meven retitled this revision from [KDirOperator] Add Backspace shortcut to cdUp action to [KDirOperator] Add Backspace shortcut to back action.Nov 20 2019, 6:40 PM
meven updated this revision to Diff 70076.Nov 20 2019, 6:43 PM

Move shortcut to Back action instead of cdUp

ngraham accepted this revision.Nov 20 2019, 6:51 PM
This revision is now accepted and ready to land.Nov 20 2019, 6:51 PM
Closed by commit R241:9550ad88a995: [KDirOperator] Add Backspace shortcut to back action (authored by meven). · Explain WhyNov 20 2019, 7:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kdiroperator.cpp (3 lines)

Diff 70080

View Options

src/filewidgets/kdiroperator.cpp

Loading...