Also enable LayoutMirroring on the dialog itself, so Widget Explorer is mirrored and its close button to the left.
Details
Details
- Reviewers
davidedmundson safaalfulaij - Group Reviewers
Plasma - Commits
- R119:4bb7ef324e8a: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left…
As suggested by Safa Alfulaij as a native speaker.
I did not test with multi-screen and cleaned up the positioning code there but maybe we still need this crude onVisibleChanged hack with QWindow trying to be smart. David?
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
We don't need my workaround
I fixed it in Qt (like a true hero) as well as doing the workaround. 71df75966db5f51c66bff1c436dd1cb5a895b51b
It's in Qt 5.6.0
I should have documented that better.
Comment Actions
Dialog has it's own positioning and sizing code.
The top line of change makes sense...(and for the same reason the killing onAvailableScreenRectChanged change makes sense, but the bindings for x,y, width and height don't...they'll just be overriden - they can't be doing anything?
Comment Actions
The height of the dialog updates just fine (it's on the mainItem and not dialog itself) with the binding but indeed the X and Y binding just break at some point.
| desktoppackage/contents/views/Desktop.qml | ||
|---|---|---|
| 139 ↗ | (On Diff #6417) |
So any fixes to x/y need to go there, not adding a second system competing. |
Comment Actions
I was wrong on both counts.
(Sorry!)
dialog.cpp only adjusts position if visualParent is set.
visualParent is not set, so x and y are in fact only set by this app.
you can set them, and you can set them normally.
the location property is effectively unused, and can be just deleted.