Differential D25347

Remove dead code
ClosedPublic
Actions

Authored by nicolasfella on Nov 16 2019, 10:23 PM.

Details

Reviewers
meven
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:ff9ae28445b4: Remove dead code
Summary

The code appears to do nothing.

Test Plan

builds, bookmarkmenu still works

Diff Detail

Repository
R318 Dolphin
Branch
deadd
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18865
Build 18883: arc lint + arc unit
nicolasfella created this revision.Nov 16 2019, 10:23 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 16 2019, 10:23 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 16 2019, 10:23 PM
meven accepted this revision.Nov 17 2019, 10:31 AM
meven added a subscriber: meven.

Was introduced in https://phabricator.kde.org/D19926 but the feature changed quite a lot in the meantime.

This revision is now accepted and ready to land.Nov 17 2019, 10:31 AM
elvisangelaccio accepted this revision.Nov 17 2019, 5:28 PM
Closed by commit R318:ff9ae28445b4: Remove dead code (authored by nicolasfella). · Explain WhyNov 25 2019, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69862

View Options

src/dolphinbookmarkhandler.h

Loading...
View Options

src/dolphinbookmarkhandler.cpp

Loading...